-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve code coverage of box types #42
Conversation
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
=========================================
+ Coverage 51.41% 54.2% +2.79%
=========================================
Files 29 29
Lines 1412 1402 -10
=========================================
+ Hits 726 760 +34
+ Misses 686 642 -44
Continue to review full report at Codecov.
|
Ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, a bit unclear whether a test case property box
should be a variable instead of a constant.
Ugh, turns out renaming a branch backing a PR is not best idea I ever had. 😅🙈 |
… and remove unused internal methods to reduce the maintenance burden.